Closed mico closed 4 weeks ago
As I understand this PR makes pubid-core ignore edition numbers because ISO IDs don't have editions.
I want to draw attention to fact that some standards have edition numbers in their IDs. For example IHO standards look like IHO S-100 1.0.0
where 1.0.0
is an edition number.
Shouldn't we implement ISO specific behavior in pubid-iso?
As I understand this PR makes pubid-core ignore edition numbers because ISO IDs don't have editions. I want to draw attention to fact that some standards have edition numbers in their IDs. For example IHO standards look like
IHO S-100 1.0.0
where1.0.0
is an edition number. Shouldn't we implement ISO specific behavior in pubid-iso?
This PR ignore edition numbers when comparing identifiers using #new_edition_of?
it doesn't affect anything else.
The reason — I still don't understand how we should compare edition numbers.
ISO have edition numbers, it was mentioned in https://github.com/metanorma/pubid-iso/issues/274
But as I understand different publishers might have different approach to edition number, so we can implement separate implementation (or extension) of #new_edition_of?
for each specific pubid-*
gem where edition numbers need to be considered for comparison.
closes #49
In this implementation I only consider year to compare editions, numbers are ignored. Need clarification on edition numbers here https://github.com/metanorma/pubid-iso/issues/274