metanorma / pubid-ieee

PubID spec and implementation for IEEE deliverables
BSD 2-Clause "Simplified" License
1 stars 0 forks source link

Spec failure due to mismatch with pubid-iso `Amendment` class #75

Closed ronaldtse closed 1 year ago

ronaldtse commented 1 year ago
Failures:

  1) Pubid::Ieee::Identifier parse specific identifiers IEEE/ISO/IEC 8802-3:2021/Amd8-2021 behaves like converts pubid to pubid converts pubid to pubid
     Failure/Error: @iso_identifier.amendment_version = iso_amendment[:version]

     NoMethodError:
       undefined method `amendment_version=' for #<Pubid::Iso::Identifier:0x0000000104a0cda0 @publisher="IEEE", @number="8802", @part="3", @copublisher=["IEC"@9, "ISO"@5], @year="2021">

                 @iso_identifier.amendment_version = iso_amendment[:version]
                                ^^^^^^^^^^^^^^^^^^^^
       Did you mean?  amendments=
     Shared Example Group: "converts pubid to pubid" called from ./spec/pubid_ieee/identifier_spec.rb:659
     # ./lib/pubid/ieee/identifier.rb:23:in `initialize'
     # ./lib/pubid/ieee/identifier.rb:72:in `new'
     # ./lib/pubid/ieee/identifier.rb:72:in `parse'
     # ./spec/pubid_ieee/identifier_spec.rb:2:in `block (2 levels) in <top (required)>'
     # ./spec/pubid_ieee/identifier_spec.rb:16:in `block (3 levels) in <top (required)>'

  2) Pubid::Ieee::Identifier parse identifiers from examples files parses identifiers from pubid-parsed.txt behaves like parse identifiers from file parse identifiers from file
     Failure/Error:
       expect do
         described_class.parse(pub_id)
       rescue Exception => failure
         raise Pubid::Ieee::Errors::ParseError,
               "couldn't parse #{pub_id}\n#{failure.message}"
       end.not_to raise_error

       expected no Exception, got #<Pubid::Ieee::Errors::ParseError: couldn't parse IEEE/ISO/IEC 8802-1Q-2020/Amd31-2021
       undefined meth... = iso_amendment[:version]
                                ^^^^^^^^^^^^^^^^^^^^
       Did you mean?  amendments=> with backtrace:
         # ./spec/pubid_ieee/identifier_spec.rb:826:in `rescue in block (6 levels) in <top (required)>'
         # ./spec/pubid_ieee/identifier_spec.rb:824:in `block (6 levels) in <top (required)>'
         # ./spec/pubid_ieee/identifier_spec.rb:823:in `block (5 levels) in <top (required)>'
         # ./spec/pubid_ieee/identifier_spec.rb:819:in `each'
         # ./spec/pubid_ieee/identifier_spec.rb:819:in `block (4 levels) in <top (required)>'
     Shared Example Group: "parse identifiers from file" called from ./spec/pubid_ieee/identifier_spec.rb:836
     # ./spec/pubid_ieee/identifier_spec.rb:823:in `block (5 levels) in <top (required)>'
     # ./spec/pubid_ieee/identifier_spec.rb:819:in `each'
     # ./spec/pubid_ieee/identifier_spec.rb:819:in `block (4 levels) in <top (required)>'

Finished in 19.78 seconds (files took 0.14582 seconds to load)
260 examples, 2 failures

Failed examples:

rspec ./spec/pubid_ieee/identifier_spec.rb[1:1:90:1:1] # Pubid::Ieee::Identifier parse specific identifiers IEEE/ISO/IEC 8802-3:2021/Amd8-2021 behaves like converts pubid to pubid converts pubid to pubid
rspec ./spec/pubid_ieee/identifier_spec.rb:817 # Pubid::Ieee::Identifier parse identifiers from examples files parses identifiers from pubid-parsed.txt behaves like parse identifiers from file parse identifiers from file