metanorma / pubid-iso

Implementation of ISO pubid
BSD 2-Clause "Simplified" License
1 stars 0 forks source link

(URGENT) Document type appears after "ISO" with slash unless there are copublishers #105

Closed ronaldtse closed 1 year ago

ronaldtse commented 2 years ago

Correct behavior:

ISO WD 1000-1.3

We are not delimiting ISO from status with a slash.

This is wrong. It should have been "ISO/WD 1000-1.3".

ISO/IEC/IEEE TR 1000-1-1:2001

  • We are not delimiting publishers from document type with a slash.

This is correct. The previous ISO/IEC/IEEE/TR pattern is wrong.

Originally posted by @ronaldtse in https://github.com/metanorma/pubid-iso/issues/102#issuecomment-1251774037

mico commented 2 years ago

@opoudjis could you help to reproduce this bug? We already have a test for that case: https://github.com/metanorma/pubid-iso/blob/main/spec/pubid_iso/identifier_spec.rb#L767 but it didn't fail.

ronaldtse commented 1 year ago

This is fixed in #115.