search

metanorma / pubid-iso

Implementation of ISO pubid
BSD 2-Clause "Simplified" License
1 stars 0 forks source link

URN rendering fails #142

Closed andrew2net closed 1 year ago

andrew2net commented 1 year ago 
> Pubid::Iso::Identifier.parse("ISO/TS 19115-3:2016").urn
     NoMethodError:
       undefined method `type' for "TS":String
     # /Users/andrej/.rvm/gems/ruby-3.0.0/gems/pubid-core-1.2.2/lib/pubid/core/renderer/base.rb:76:in `render'
     # /Users/andrej/.rvm/gems/ruby-3.0.0/gems/pubid-iso-0.2.1/lib/pubid/iso/identifier.rb:108:in `urn'
     ...
ronaldtse commented 1 year ago

@mico this is urgent, thanks.

mico commented 1 year ago

@andrew2net added test for your case but it didn't fall. Only it doesn't render year, but we don't render year for URN, only edition if it's provided.

andrew2net commented 1 year ago

@mico I get this error with versions

bundle list |grep pubid
  * pubid-core (1.2.2)
  * pubid-iso (0.2.1)

no any errors with pubid-core (1.2.1)

mico commented 1 year ago

@andrew2net I just published pubid-iso 0.2.2, try it. There were many changes since 0.2.1