metanorma / pubid-iso

Implementation of ISO pubid
BSD 2-Clause "Simplified" License
1 stars 0 forks source link

chore: cleanup publisher rendering #161

Closed ronaldtse closed 2 years ago

ronaldtse commented 2 years ago

Depends on https://github.com/metanorma/pubid-core/pull/9

Metanorma PR checklist

ronaldtse commented 2 years ago

There are some more fixes to be made here. @mico can you please help? Thanks.

Also we need to merge https://github.com/metanorma/pubid-core/pull/9 first, and then remove the line pointing to that repo from the Gemfile.

ronaldtse commented 2 years ago

Failures:

Failures:

  1) Pubid::Iso::Identifier ISO/IEC/IEEE 26512 behaves like converts pubid to pubid converts pubid to pubid
     Failure/Error: expect(subject.to_s(format: :ref_num_long)).to eq(pubid)

       expected: "ISO/IEC/IEEE 26512"
            got: "ISO/IEEE/IEC 26512"

       (compared using ==)
     Shared Example Group: "converts pubid to pubid" called from ./spec/pubid_iso/identifier/identifier_spec.rb:63
     # ./spec/support/convert_pubid.rb:9:in `block (2 levels) in <top (required)>'

  2) Pubid::Iso::Identifier GUIDE ISO/CEI 71:2001(F) behaves like converts pubid to french pubid converts pubid to french pubid
     Failure/Error: expect(subject.to_s(format: :ref_num_long, lang: :french)).to eq(french_pubid)

       expected: "Guide ISO/CEI 71:2001(fr)"
            got: "Guide ISO/CEI  71:2001(fr)"

       (compared using ==)
     Shared Example Group: "converts pubid to french pubid" called from ./spec/pubid_iso/identifier/identifier_spec.rb:372
     # ./spec/support/convert_pubid.rb:21:in `block (2 levels) in <top (required)>'

  3) Pubid::Iso::Identifier ISO/IEC 17025:2005/Cor.1:2006(fr) behaves like converts pubid to french pubid converts pubid to french pubid
     Failure/Error: expect(subject.to_s(format: :ref_num_long, lang: :french)).to eq(french_pubid)

       expected: "ISO/CEI 17025:2005/Cor.1:2006(fr)"
            got: "ISO/IEC 17025:2005/Cor.1:2006(fr)"

       (compared using ==)
     Shared Example Group: "converts pubid to french pubid" called from ./spec/pubid_iso/identifier/identifier_spec.rb:408
     # ./spec/support/convert_pubid.rb:21:in `block (2 levels) in <top (required)>'

  4) Pubid::Iso::Identifier Руководство ИСО/МЭК 76 behaves like converts pubid to russian pubid converts pubid to russian pubid
     Failure/Error: expect(subject.to_s(format: :ref_num_long, lang: :russian)).to eq(russian_pubid)

       expected: "Руководство ИСО/МЭК 76"
            got: "Руководство ИСО/МЭК  76"

       (compared using ==)
     Shared Example Group: "converts pubid to russian pubid" called from ./spec/pubid_iso/identifier/identifier_spec.rb:437
     # ./spec/support/convert_pubid.rb:27:in `block (2 levels) in <top (required)>'

  5) Pubid::Iso::Identifier ИСО/ОПМС 26000:2010(R) behaves like converts pubid to russian pubid converts pubid to russian pubid
     Failure/Error: expect(subject.to_s(format: :ref_num_long, lang: :russian)).to eq(russian_pubid)

       expected: "ИСО/ОПМС 26000:2010(ru)"
            got: "ОПМС 26000:2010(ru)"

       (compared using ==)
     Shared Example Group: "converts pubid to russian pubid" called from ./spec/pubid_iso/identifier/identifier_spec.rb:448
     # ./spec/support/convert_pubid.rb:27:in `block (2 levels) in <top (required)>'

  6) Pubid::Iso::Identifier ISO/IEC/IEEE DTS 17301-1-1:2016(en) behaves like converts pubid to pubid converts pubid to pubid
     Failure/Error: expect(subject.to_s(format: :ref_num_long)).to eq(pubid)

       expected: "ISO/IEC/IEEE DTS 17301-1-1:2016(en)"
            got: "ISO/IEEE/IEC DTS 17301-1-1:2016(en)"

       (compared using ==)
     Shared Example Group: "converts pubid to pubid" called from ./spec/pubid_iso/identifier/identifier_spec.rb:530
     # ./spec/support/convert_pubid.rb:9:in `block (2 levels) in <top (required)>'

  7) Pubid::Iso::Identifier ISO/IEC/IEEE FDTR 17301-1-1:2016(en) behaves like converts pubid to pubid converts pubid to pubid
     Failure/Error: expect(subject.to_s(format: :ref_num_long)).to eq(pubid)

       expected: "ISO/IEC/IEEE FDTR 17301-1-1:2016(en)"
            got: "ISO/IEEE/IEC FDTR 17301-1-1:2016(en)"

       (compared using ==)
     Shared Example Group: "converts pubid to pubid" called from ./spec/pubid_iso/identifier/identifier_spec.rb:536
     # ./spec/support/convert_pubid.rb:9:in `block (2 levels) in <top (required)>'