search

metanorma / pubid-iso

Implementation of ISO pubid
BSD 2-Clause "Simplified" License
1 stars 0 forks source link

Pubid::Iso fails to parse Add identifiers #206

Closed andrew2net closed 1 year ago

andrew2net commented 1 year ago

Pubid::Iso fails to parse identifiers like these: ISO 1942:1983/Add 1:1983/Add 6:1985 ISO 1942:1983/Add 1:1983 ISO 1942:1983/Add 1:1983/Add 3:1983 ISO 1942:1983/Add 1:1983/Add 2:1983 ISO 1942:1983/Add 1:1983/Add 5:1985 ISO 1942:1983/Add 1:1983/Add 4:1984 ISO 5742:1982/Add 1:1985 ISO/TR 8373:1988/Add 1:1990

Originally posted by @andrew2net in https://github.com/relaton/relaton-iso/issues/144#issuecomment-1411286100

ronaldtse commented 1 year ago

Thank you @andrew2net for raising this! These pubids are notable and we need to support them.

@mico can you help here? Thanks.

This is a blocker to https://github.com/relaton/relaton-iso/issues/144#issuecomment-1411286100

mico commented 1 year ago

Thank you @andrew2net for raising this! These pubids are notable and we need to support them.

@mico can you help here? Thanks.

ISO 1942:1983/Add 1:1983/Add 6:1985

@ronaldtse Is it an addendum on top of another addendum, or just 2 addendums applied to the same base identifier? (we have these two approaches for supplements too)

ronaldtse commented 1 year ago

"ISO 1942:1983/Add 1:1983/Add 6:1985" appears to be the 6th addendum on Addendum 1. Here, "ISO 1942:1983/Add 1:1983" is the base identifier.

ronaldtse commented 1 year ago

However this is strange because there is no "ISO 1942:1983/Add 1:1983/Add 1". Let me ask ISO and find out whether these are mistakes.

ronaldtse commented 1 year ago

@mico for now please help handle these first:

ISO 5742:1982/Add 1:1985
ISO/TR 8373:1988/Add 1:1990
ronaldtse commented 1 year ago

Since #208 addresses the issue, except the strange identifiers, I will move the remaining to a new issue.