Amendment/Corrigendum number cannot be rendered with a colon

metanorma / pubid-iso

Implementation of ISO pubid

BSD 2-Clause "Simplified" License

1 stars 0 forks source link

Amendment/Corrigendum number cannot be rendered with a colon #80

Closed ronaldtse closed 2 years ago

ronaldtse commented 2 years ago

irb(main):011:0> Pubid::Iso::Identifier.new(number: 17301, part: 1, publisher: "ISO", language: "en", year: 2016, amendments: [{number: 1, stage: "NP"}]).to_s
=> "ISO 17301-1:2016/NP Amd :1(en)"

The output is wrong, it should be: "ISO 17301-1:2016/NP Amd 1(en)"

mico commented 2 years ago

@ronaldtse is it ok that PubID with edition year don't have edition year in generated URN? ISO 19110:2005/Amd 1:2011 -> urn:iso:std:iso:19110:amd:2011:v1 That's how it works now.

Not sure to which task leave this comment.