Closed andrew2net closed 1 year ago
@mico this is a bug to be fixed, thanks. The "FIPS" documents do not have the "NIST" prefix.
@mico this is a bug to be fixed, thanks. The "FIPS" documents do not have the "NIST" prefix.
@ronaldtse Andrei's point was about "FIPS PUB" vs "FIPS". Source datasets don't have a "PUB" part. @andrew2net is it correct?
@mico yes, the question was about "FIPS PUB" vs "FIPS". However, I was wrong adding NIST prefix to all the IDs. The pubs-export dataset has FIPS and SP series. SP series should be prefixed with NIST but FISP shouldn't. So we have two issues now:
@ronaldtse I don't know if "FIPS PUB" sereis exists. Can you confirm if it exists or no?
@ronaldtse I don't know if "FIPS PUB" sereis exists. Can you confirm if it exists or no?
https://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.140-2.pdf
Everywhere in the document it appears as FIPS PUB 140-2
https://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.197-upd1.pdf
This one mentioned as FIPS 197
in the document, but in the document it says:
How to Cite This Publication. NIST has assigned NIST FIPS 197-upd1 as the publication identifer for this FIPS, per the NIST Technical Series Publication Identifer Syntax.
In the series abbreviations here https://www.nist.gov/system/files/documents/2022/04/01/PubID_Syntax_NIST_TechPubs.pdf "FIPS" don't have part "PUB", but the old identifiers have (https://nvlpubs.nist.gov/nistpubs/Legacy/FIPS/fipspub46-1.pdf).
I think based on latest updates and standards, we should add NIST before "FIPS", but we don't need "PUB" in the output.
@mico I see that the PDF documents have "FISP PUB" series. But the IDs in the data source and on the site are without "PUB". https://csrc.nist.gov/pubs/fips/140-2/upd1/final https://csrc.nist.gov/pubs/fips/140-2/final https://csrc.nist.gov/pubs/fips/140-2/final
Now this gem can parse "FIPS 140-2" without "NIST" prefix. It's good. However, it still render pbid with "NIST" prefix.
> pry(main)> Pubid::Nist::Identifier.parse('FIPS 140-2').to_s
=> "NIST FIPS 140-2"
However, it still render pbid with "NIST" prefix
@andrew2net According to standard https://www.nist.gov/system/files/documents/2022/04/01/PubID_Syntax_NIST_TechPubs.pdf we should render "FIPS" prefixed with "NIST". I already mentioned this above.
@mico I missed it, sorry.
Thank you @mico @andrew2net , I agree with the current implementation as per PubID 1.0.
When parsing "NIST FIPS 140-2" and rendering it we get "NIST FIPS PUB 140-2"
There aren't "NIST FIPS PUB NNN" documents in the source datasets that we use. There are only "NIST FIPS NNN"