search

metanorma / vectory

Convert between vector image formats (Ruby)
2 stars 0 forks source link

thor dependency too strict #30

Closed eneagoe closed 9 months ago

eneagoe commented 9 months ago

https://github.com/metanorma/vectory/blob/e3bd5fc2d121276f10a968e6b0e7e81516abbba5/vectory.gemspec#L33

thor 1.3.0 is already out - can this dependency be relaxed? It prevents updates of rails apps that depend on html2doc and implicitly on this gem.

opoudjis commented 9 months ago

This... isn't great, @alexeymorozov :

fontist/fontist.gemspec:  spec.add_runtime_dependency "thor", "~> 1.2.1"
lutaml-uml/lutaml-uml.gemspec:  spec.add_runtime_dependency "thor", "~> 1.0"
metanorma-cli/metanorma-cli.gemspec:  spec.add_runtime_dependency "thor", "~> 1.0"
pubid-nist/pubid-nist.gemspec:  spec.add_dependency "thor"
relaton-cli/relaton-cli.gemspec:  spec.add_runtime_dependency "thor"
reverse_asciidoctor/reverse_adoc.gemspec:  # spec.add_runtime_dependency "thor"
vectory/vectory.gemspec:  spec.add_runtime_dependency "thor", "~> 1.2.1"

This means you need to contact the people maintaining fontist (yourself :-) , lutaml-uml (not currently maintain, so I think it's also yourself), and metanorma-cli (me) to make sure we're all on the same version of thor. I'll take out the metanorma-cli, since it is now being inherited from other gems, effective next release (Monday).

Not aware of a direct dependency of html2doc on thor; my Gemfile.lock for html2doc in isolation only lists vectory, and guard (thor (>= 0.18.1)). @eneagoe are you seeing something different?

eneagoe commented 9 months ago

That is correct, html2doc does not directly depend on thor.

alexeymorozov commented 9 months ago

@eneagoe @opoudjis Of course, I'll loosen it, it seems reasonable 👍

P.S. Thanks for mentioning the issue and me! Seems I wasn't subscribed to all events of vectory, so I missed a new issue. Now I'm subscribed, I hope I won't miss any new ones.

alexeymorozov commented 9 months ago

Released in v0.7.2