metaopt / optree

OpTree: Optimized PyTree Utilities
https://optree.readthedocs.io
Apache License 2.0
146 stars 7 forks source link

refactor: reorder cases for `namedtuple` and `PyStructSequence` types #111

Closed XuehaiPan closed 11 months ago

XuehaiPan commented 11 months ago

Description

Describe your changes in detail.

Move the PyStructSequence check before the namedtuple check.

Motivation and Context

Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. You can use the syntax close #15213 if this solves the issue #15213

The PyStructSequence types will be more similar to the namedtuple types in the future. It's hard to distinguish these two types if the PyStructSequence types will have _fields attributes.

This PR moves the PyStructSequence type check before the namedtuple type check.

Checklist

Go over all the following points, and put an x in all the boxes that apply. If you are unsure about any of these, don't hesitate to ask. We are here to help!

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (442fecc) 100.00% compared to head (0467bb7) 100.00%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #111 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 8 8 Lines 708 708 ========================================= Hits 708 708 ``` | [Flag](https://app.codecov.io/gh/metaopt/optree/pull/111/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=metaopt) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/metaopt/optree/pull/111/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=metaopt) | `100.00% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=metaopt#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.