metaopt / optree

OpTree: Optimized PyTree Utilities
https://optree.readthedocs.io
Apache License 2.0
136 stars 6 forks source link

[Feature Request] Setup Clang-Tidy #18

Closed Skylion007 closed 1 year ago

Skylion007 commented 1 year ago

Required prerequisites

Motivation

Ensures code quality remains good and catches simple perf mistakes. I see you install it in the makefile but without a clang-tidy config specifying what checks and what the header-filter is, it's easy to miss things.

Solution

Install clang-tidy preferrably as a Github Action.

Alternatives

No response

Additional context

No response

XuehaiPan commented 1 year ago

@Skylion007 Thanks for the suggestion. We installed the clang-tidy but forgot to add the Makefile target to enable this check. We will work on this.