metaopt / optree

OpTree: Optimized PyTree Utilities
https://optree.readthedocs.io
Apache License 2.0
136 stars 6 forks source link

style: remove useless move found via clang-tidy #19

Closed Skylion007 closed 1 year ago

Skylion007 commented 1 year ago

Signed-off-by: Aaron Gokaslan aaronGokaslan@gmail.com

Description

Describe your changes in detail.

Motivation and Context

Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. You can use the syntax close #15213 if this solves the issue #15213

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

Checklist

Go over all the following points, and put an x in all the boxes that apply. If you are unsure about any of these, don't hesitate to ask. We are here to help!

codecov-commenter commented 1 year ago

Codecov Report

Base: 94.04% // Head: 94.04% // No change to project coverage :thumbsup:

Coverage data is based on head (0c0cdf2) compared to base (8bb8801). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #19 +/- ## ======================================= Coverage 94.04% 94.04% ======================================= Files 4 4 Lines 319 319 ======================================= Hits 300 300 Misses 19 19 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `94.04% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=metaopt#carryforward-flags-in-the-pull-request-comment) to find out more. Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=metaopt). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=metaopt)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

XuehaiPan commented 1 year ago

@Skylion007 could you update the commit with make format. Then we can get it merged.

Skylion007 commented 1 year ago

@XuehaiPan done

Skylion007 commented 1 year ago

BTW, instead of make format, consider pre-commit as it could apply changes like clang-format automatically to PRs

XuehaiPan commented 1 year ago

@Skylion007 Thanks for your contribution and suggestions.