search

metaparticle-io / package

Metaparticle/Package: Language Fluent Containerization and Deployment in Java, .NET and Javascript (and more coming soon)
https://metaparticle.io
MIT License
493 stars 55 forks source link

test: add first tests when testing for env variable #59

Closed pfongkye closed 6 years ago

pfongkye commented 6 years ago

Still need to add tests for options argument

pfongkye commented 6 years ago

@brendanburns can you confirm me that it should be options.dockerfile instead of src when looking at code pointer?

brendandburns commented 6 years ago

Yes, that's correct. Thanks for catching that bug!

brendandburns commented 6 years ago

@pfongkye LGTM, but did you fix that dockerfile bug you found?

pfongkye commented 6 years ago

@brendanburns I created a separate PR: https://github.com/metaparticle-io/package/pull/61

brendandburns commented 6 years ago

LGTM, thanks!