search

metaparticle-io / package

Metaparticle/Package: Language Fluent Containerization and Deployment in Java, .NET and Javascript (and more coming soon)
https://metaparticle.io
MIT License
493 stars 55 forks source link

add go dep to the dockerfile for go example app #60

Closed smothiki closed 6 years ago

smothiki commented 6 years ago

I was trying the example and hit with the below error 

../../metaparticle/docker_impl.go:57: cannot use dockerClient (type *client.Client) as type dockerImageClient in field value:
    *client.Client does not implement dockerImageClient (wrong type for ImageBuild method)
        have ImageBuild("github.com/docker/docker/vendor/golang.org/x/net/context".Context, io.Reader, types.ImageBuildOptions) (types.ImageBuildResponse, error)
        want ImageBuild("context".Context, io.Reader, types.ImageBuildOptions) (types.ImageBuildResponse, error)
../../metaparticle/docker_impl.go:57: cannot use dockerClient (type *client.Client) as type dockerContainerRunner in field value:
    *client.Client does not implement dockerContainerRunner (wrong type for ContainerCreate method)
        have ContainerCreate("github.com/docker/docker/vendor/golang.org/x/net/context".Context, *container.Config, *container.HostConfig, *network.NetworkingConfig, string) (container.ContainerCreateCreatedBody, error)
        want ContainerCreate("context".Context, *container.Config, *container.HostConfig, *network.NetworkingConfig, string) (container.ContainerCreateCreatedBody, error)

go-wrapper downloads the packages as it is and nested vendor folders can cause this issue. It would be nice if officail golang image comes with go dep but it isn't. Suggestions welcome

brendandburns commented 6 years ago

LGTM, thanks!