search

metaparticle-io / package

Metaparticle/Package: Language Fluent Containerization and Deployment in Java, .NET and Javascript (and more coming soon)
https://metaparticle.io
MIT License
493 stars 55 forks source link

Request support for more source images via Config #85

Open cdhunt opened 6 years ago

cdhunt commented 6 years ago

My motivation is to include support for Windows containers. I think all that's required is making the following values configurable. At least for dotnet. https://github.com/metaparticle-io/package/blob/89cc3178bac32a56ca4868a8ccde3605e12637ac/dotnet/Metaparticle.Package/Metaparticle.cs#L135-L136

This was mentioned in #53 and #51. I don't think #51 addresses this sufficiently. If I have to maintain a separate Dockerfile, then I lose much of the value of Metaparticle.

brendandburns commented 6 years ago

Yeah, I can definitely see introducing the ability to customize the 'FROM' makes a ton of sense.

Want to do the PR?