Adding unit tests for Transaction Message compilation and fixing public key sorting issue - Githubissues

metaplex-foundation / SolanaKT

This is a open source library on kotlin for Solana protocol.

MIT License

69 stars 37 forks source link

Adding unit tests for Transaction Message compilation and fixing public key sorting issue #109

Closed MirekR closed 2 years ago

MirekR commented 2 years ago

Description

Kotlin implementation was returning different result on Transaction.compileMessage() compare to solana/web3.js implementation. This was causing issues with partially signed messages from server (NodeJs + Typescript)

Work Completed

Added subset of unit tests as copy from solana/web3.js (https://github.com/solana-labs/solana-web3.js/blob/71419862c876c1672a2d452684eb388d182b7294/test/transaction.test.ts)
Updated sorting of instruction keys to get aligned with js implementation.

ajamaica commented 2 years ago

Great catch!