Closed MirekR closed 2 years ago
Cool, I'll wait until you merge your change and will get back to this later. Thanks :)
It's now merged. Thanks again for your contribution
Alreet, I merged your code and updated my changes but I'm running in issues in tests ...
TestGetConfirmedBlock with exception
Transaction version (0) is not supported by the requesting client. Please try the request again with the following configuration parameter: "maxSupportedTransactionVersion": 0
Have you seen that?
It looks like the latest block is already containing version transaction what is not supported yet (unless I'm missing something).
I've updated tests to use fixed slot for test for now. Does that sounds ok to you?
That's ok but then we need another issue for reading this
@MirekR lets file a new issue and solve that on a new PR
Yeap, I've created new issue for it - https://github.com/metaplex-foundation/SolanaKT/issues/112
Thanks, @ajamaica and btw, the new serialisation looks good, great work.
It was a big effort
It was :)
Is there anything else in this PR you'd like me to change or you happy to merge this?
@MirekR I want the other PR https://github.com/metaplex-foundation/SolanaKT/pull/110 and then this one
We merge the changes. There is a conflict for sendTransaction. I think is only the imports. Is it too much to ask if you rebase?
That's now conflicts resolved :)
This can go in thanks a lot
Description
Work Completed