search

metaplex-foundation / SolanaKT

This is a open source library on kotlin for Solana protocol.
MIT License
71 stars 36 forks source link

Fix a small bug in NetworkingRouter #129

Closed creativedrewy closed 1 year ago

creativedrewy commented 1 year ago

Description

Prior to this fix, in NetworkingRouter.kt, when an error response comes in, the class would still try and read from inputStream. In the error case, that may not exist, so it throws an exception.

Work Completed

This PR fixes the bug in NetworkingRouter. It mirrors a fix that was made by @Funkatronics in the other metaplex kt lib.

Funkatronics commented 1 year ago

I give my blessing but want to let @ajamaica take the final call

Funkatronics commented 1 year ago

this mirrors the fix made here

creativedrewy commented 1 year ago

@ajamaica can you re-run the CI

ajamaica commented 1 year ago

Hey! I was on a flight. Sorry for not seeing this.

Funkatronics commented 1 year ago

Thanks Arturo! Do you know whats up with the CI? lmk if you need some help with that

ajamaica commented 1 year ago

Not sure. I am giving time for this next months.