Closed etodanik closed 2 years ago
You have changed 'burnToken' params name and docs, specifically, 'token' to 'account'.
This leads to confusion since docs are pointing out to latest changed done in master branch - https://metaplex-foundation.github.io/js/interfaces/actions.BurnTokenParams.html
However, NPM packages goes only up to v4.12.0 which doesnt contain the changes above.
Sending param as doc states with 'account' will cause an exception.
Many hours lost on this, shouldn't there be a new NPM package with next tag so docs are in full correlation with latest available package via NPM?
@aheckmann
Yes , this was in the plan but then this was frozen and I didn’t get updates. It should 100% be updated everywhere.
Token is an absolutely incorrect name for it. It’s an account. Naming it token can make it seem like you’re expecting a token mint, when in reality you’re to provide the account where this token will be stored.
Current Status: This is still a draft. I'm planning to finish an initial pass documenting most of the actions by EOD Jan 22nd and then move on to adding inline code examples and more detailed usage documentation as a second pass after which I'll switch the PR to a ready for review mode.
Pull request to track typedoc documentation.
Some changes not related to docs for review:
doc:watch
command to be able to doyarn doc:watch
and write docs easilyI
prefixes from interfaces as I encounter them (ICancelBidParams
becomesCancelBidParams
) because we had a mixed bag and TypeScript mostly discourages prefixed interfaces