metaplex-foundation / js-deprecated

Deprecated Metaplex JavaScript SDK
https://metaplex-foundation.github.io/js/
MIT License
128 stars 77 forks source link

ft(export-unsigned-transaction): Export instructions to merge into bigger transaction #190

Open VIIGstar opened 2 years ago

VIIGstar commented 2 years ago

Problem: As I can see from your metaplex web, when we take an action like selling NFT, we need to sign only one times to process createVault, addTokensToVault, activeVault, ... Our code may go out-of-date if not use from npm

Solution: Should we return a transactionBatch to use in a bigger transaction (sign one times) instead of calling these actions (actions.createExternalPriceAccount, actions.createVault...) and request users to approve for each transaction

If you OK, I will modify more function and find some pattern to reduce duplicate code check isUninitialized