search

metaplex-foundation / js-deprecated

Deprecated Metaplex JavaScript SDK
https://metaplex-foundation.github.io/js/
MIT License
127 stars 77 forks source link

fix: don't rely on explicit export of TransactionCtorFields type #205

Closed steveluscher closed 2 years ago

steveluscher commented 2 years ago

This is our bad. We:

  1. Over-export fundamentally private types from @solana/web3.js just so that TypeDoc can generate documentation for them. This has to stop.
  2. Didn't stop to think that someone might have imported those types for use.

In this PR I replace the recently-renamed TransactionCtorFields type with a type that derives it, for all current and future versions of web3.js. This will not break again, no matter how many times the parameter gets renamed.

Fixes #202.

steveluscher commented 2 years ago

Please also ship https://github.com/metaplex-foundation/metaplex-program-library/pull/507.

lorisleiva commented 2 years ago

As discussed, I'm closing this PR since we are deprecating this SDK in favour of the new one.