search

metaplex-foundation / js

A JavaScript SDK for interacting with Metaplex's programs
357 stars 182 forks source link

Implement ArweaveStorageDriver #1

Closed lorisleiva closed 1 year ago

lorisleiva commented 2 years ago

Without using Bundlr. Inspired by https://github.com/metaplex-foundation/metaplex/blob/master/js/packages/cli/src/helpers/upload/arweave.ts but needs to works with the identity driver — i.e. can be a keypair or a wallet adapter.

anoushk1234 commented 2 years ago

@lorisleiva im trying to implement this and it would help to have some more context of how it must be implemented, maybe some pseudocode.

lorisleiva commented 2 years ago

I'm not sure how yet but I was planning on following a similar approach to how we do it in the Candy Machine CLI here.

anoushk1234 commented 2 years ago

I'm not sure how yet but I was planning on following a similar approach to how we do it in the Candy Machine CLI here.

Got that but how should it integrate with Identity driver?

lorisleiva commented 2 years ago

If the identity driver is a KeypairIdentityDriver then it should be very similar, otherwise, we'd need to find a way to make it work with wallet adapters which would be the hard bit. I'm not sure how to do this right now though, I'd need to dig into it.

github-actions[bot] commented 1 year ago

Hi @lorisleiva,

Thank you for raising this!

We'd like to make sure our GitHub issue tracker remains the best place to manage issues that affect the development of the Metaplex JS SDK itself. It looks like your issue is suggesting an improvement rather than raising a bug.

Unless there exists evidence that this is a bug with the JS SDK itself, please use our Feature Request boards to create new posts or upvote existing ones. You may use the following links to access the JS SDK Feature Request board:

https://metaplex.canny.io/developers?category=js-sdk-tools

If you could please share the link to the relevant Feature Request here afterwards, that would be very helpful for anyone following this thread.

This automated message is a result of having added the "feature request" label.