search

metaplex-foundation / js

A JavaScript SDK for interacting with Metaplex's programs
359 stars 183 forks source link

`animation_url` field discrepancy with docs and `JsonMetadata` type #500

Closed nicholas-ewasiuk closed 1 year ago

nicholas-ewasiuk commented 1 year ago

Token Metadata standard documentation https://docs.metaplex.com/programs/token-metadata/token-standard shows an animation_url field. The JsonMetadata type is missing the animation_url field. https://github.com/metaplex-foundation/js/blob/main/packages/js/src/plugins/nftModule/models/JsonMetadata.ts

Which is the correct info? Should the animation_url be included in that JsonMetadata type?

lorisleiva commented 1 year ago

Hi there, animation_url is a valid optional attribute of the JSON metadata. It is just missing from the JsonMetadata type.

nicholas-ewasiuk commented 1 year ago

Okay, thanks for the response Loris. Can I submit a PR to add it to the JsonMetadata type?

lorisleiva commented 1 year ago

Yes, that would be helpful thank you!

lorisleiva commented 1 year ago

Fixed by #502