metaplex-foundation / js

A JavaScript SDK for interacting with Metaplex's programs
355 stars 182 forks source link

[feat]: fetching all minted NFTs from a Candy Machine #53

Closed thlorenz closed 2 years ago

laurensV commented 2 years ago

Don't we already have this feature with the function metaplex.nfts().findAllByCandyMachine?

thlorenz commented 2 years ago

You may be right @lorisleiva wouldn't that method work for it or do you just want me to add a method to the candy machine module itself that calls it for easier discovery of that API?

lorisleiva commented 2 years ago

I added it there until we had the candy machine module basically.

But ideally, we should keep nfts().findAllByCreator(...) and move nfts().findAllByCandyMachine(...) to the candy machine module as something like candyMachines().findAllMintedNfts(...).

lorisleiva commented 2 years ago

This method has been moved to the candy machine module as described above.