Fix HTTP Error Handling added in #100

metaplex-foundation / metaplex-android

Metaplex Mobile Android SDK

18 stars 12 forks source link

Closed Funkatronics closed 1 year ago

Funkatronics commented 1 year ago

made a mistake in my previous pr (#100) that was causing fatal errors to still get through, that is now fixed
added output error handling (fixes fatal error if the http request is bad)

ran all unit tests, verified that this change does not impact any existing calls or error handling
confirmed this change works locally by simulating bad requests

Funkatronics commented 1 year ago

Sorry @ajamaica, mad a mistake in my previous PR!

Big thanks to @creativedrewy for catching this!

ajamaica commented 1 year ago

Please rebase

Funkatronics commented 1 year ago

Help me obi wan jamacia, you're my only hope 🙏🏽

ajamaica commented 1 year ago

The issue is the transfer airdrop the code it's fine. We can merge it