Add findByMint API for fungible tokens

metaplex-foundation / metaplex-android

Metaplex Mobile Android SDK

18 stars 12 forks source link

Add findByMint API for fungible tokens #58

Closed thedevyansh closed 2 years ago

thedevyansh commented 2 years ago

Description

This PR supports finding the fungible token metadata through the mint account.

Work Completed

Added a new API, findByMint(mint, callback), which will return the on-chain metadata of fungible token for a given mint address. This API is a part of the tokenMetadata module.

Usage

metaplex.tokenMetadata.findByMint(mintPublicKey){
    it.onSuccess { fungibletoken ->
        ...
    }.onFailure { 
        ...
    }
}

Testing

Android Studio Debugger
Unit testing using JUnit

Funkatronics commented 2 years ago

@thedevyansh would love to see some unit tests so we can verify the behavior. You could look at the existing tests for the nft module and probably copy the test code for similar findbymint stuff from there to get you started.

Funkatronics commented 2 years ago

This looks good to me @thedevyansh. We will probably refactor the tests a bit to use the new mocked network layer but what you have done here is fine for your task.

Funkatronics commented 2 years ago

oh @thedevyansh please target the develop branch for merge instead of main. Thanks!