search

metaplex-foundation / metaplex-android

Metaplex Mobile Android SDK
18 stars 12 forks source link

Update SolanaKT version 1.1.5 -> 1.2 #70

Closed MirekR closed 2 years ago

MirekR commented 2 years ago

Description

Funkatronics commented 2 years ago

Hi @MirekR, appreciate the PR, but we have a strategy in place for upgrading our solana dependency. We have a separate effort to upgrade to the latest Solana release that @ajamaica is currently working on.

We have changed much of the SDK recently, and the changes in SolanaKt 1.2.0 will actually break the work we currently have in development (see the develop branch). Its not worth updating the main branch at this time, as the changes will both conflict and be overwritten by the work in development.

Funkatronics commented 2 years ago

@MirekR Really appreciate your interest in contributing to the SDK here! I recommend that you check out the develop branch to see the latest code. All PRs should target the develop branch, not main FYI.

If you're are interesting in contributing further, please reach out to me on twitter @Soonganoid and I can give you some additional info on how to best contribute to our efforts here. Thanks so much!

MirekR commented 2 years ago

Hi @Funkatronics, thanks for quick response. I'll have a look over the weekend what's on the develop branch and will get in touch. It would be good to get the SolanaKT upgraded - selfishly for us, as we're using the 1.2.0 version and now after including the metaplex library, it causing us some issues. Do you have or @ajamaica have any estimates when the current work will be done?