search

metaplex-foundation / metaplex-ios

Metaplex Mobile IOS SDK
23 stars 21 forks source link

Update installation wording on par with Xcode 14 #58

Closed iiqrah closed 1 year ago

iiqrah commented 2 years ago

While forking/cloning and getting the app to run locally, I found the steps mentioned in the Installation section to be outdated for Xcode 14.

I have gone ahead and made the changes on par with Xcode 14.

Let me know if you'd like me to modify the changes in any way.

Thanks! :)

iiqrah commented 1 year ago

Heya @mike-metaplex, just wondering how to get this PR merged 😅

mike-metaplex commented 1 year ago

Heya @mike-metaplex, just wondering how to get this PR merged 😅

It looks like I'm not able to re-run the build checks. Also I tried to pull your branch to rebase, but I'm not able to. Could you push your branch again please?

iiqrah commented 1 year ago

I am not too sure if I pushed it correctly as intended but hopefully the build check will pass now? Or we can close this PR and I can do a fresh set-up and make the README changes. I noticed that for some reason both my GitHub accounts are linked to this PR (unintentionally) so idk if that is also contributing to the error.