search

metaplex-foundation / metaplex-program-library

Smart contracts maintained by the Metaplex team
Other
580 stars 510 forks source link

[Bug]: 0.3.2 feature cleanup is a breaking change #1159

Open ellttBen opened 1 year ago

ellttBen commented 1 year ago

Which package is this bug report for?

mpl_utils

Which Type of Package is this bug report for?

Rust library

Issue description

The https://github.com/metaplex-foundation/metaplex-program-library/commit/f957f2dfdb1b979004f8c7160f8fea0e0e176c2b commit , which was deployed with mpl_utils 0.3.2 , introduces a breaking change because the token feature is no longer activated by default. This breaks using mpl_token_metadata as a dependency, and requires manually reverting mpl_utils to 0.3.1 to compile: mpl_token_metadata depends on mpl_utils without specifying the token feature, but uses it here.

My personal recommendation is to publish a 0.3.3 version with the token feature still as default, and postpone clearing this default until a 0.4.x.

Relevant log output

No response

Priority this issue should have

High (immediate attention needed)

acheroncrypto commented 1 year ago

My personal recommendation is to publish a 0.3.3 version with the token feature still as default, and postpone clearing this default until a 0.4.x.

+1. Making changes to how features work is almost always a breaking change, therefore they should be versioned as a breaking change.