search

metaplex-foundation / metaplex-program-library

Smart contracts maintained by the Metaplex team
Other
588 stars 513 forks source link

Setup Auto Crate Publishing to MPL #124

Closed austbot closed 1 year ago

jshiohaha commented 2 years ago

Currently, a bot will update the version found in Cargo.toml on PR merge if a contributor/mmeber left a review comment that says patch, minor, or major. It will also make the commit, add the repo tag, and push the commit.

This is the most simple version of the workflow. In the future, maybe we can specify more granular version updates that include package manager & package, such as patch:rust or patch:rust:auction-house. Any follow-on functionality will be dependent on how this first test goes.

jshiohaha commented 2 years ago

I missed the fact that a Cargo.toml version bump also means we should update the IDL & Cargo.lock files as well. Based on this sample version bump PR: https://github.com/metaplex-foundation/metaplex-program-library/pull/535/files

I'm thinking the workflow will be similar to the current implementation. We just need to include the IDL in the files that the bot commits and pushes as part of a version update.

thlorenz commented 2 years ago

We just need to include the IDL in the files that the bot commits and pushes as part of a version update.

Well and obviously also the re-generated TS needs to be included.

An alternative solution is to build in a check that yarn api:gen doesn't result in any changes thus ensuring that the PR author took care of that. I'd prefer that actually since you might discover other issues (like failing SDK tests in the modules that have them) after you re-generate.