search

metaplex-foundation / metaplex-program-library

Smart contracts maintained by the Metaplex team
Other
591 stars 517 forks source link

[Bug]: punish_bots returns Ok() instead of error #574

Closed 0xabstracted closed 2 years ago

0xabstracted commented 2 years ago

Which package is this bug report for?

candy-machine

Which Type of Package is this bug report for?

Rust Contract

Issue description

After punish_bots is called we are returning Ok(()), which will let the instruction pass and will make look like the whole mint transaction is successful and it leaves the associated token accounts and mint coounts open. As a result tokens without metadata are shown in wallets.

Relevant log output

No response

Priority this issue should have

Low (slightly annoying)

samuelvanderwaal commented 2 years ago

If you fail the transaction the bots don't actually get charged so the transaction has to pass.

febo commented 2 years ago

Indeed, in oder to charge the bot fee, the transaction has to succeed. I will close this issue since this is the intended behaviour.