metaplex-foundation / metaplex

A directory of what the Metaplex Foundation works on!
https://metaplex.com
Apache License 2.0
3.32k stars 6.26k forks source link

[Bug]: unkown collection on phantom, good on solscan ? #2163

Closed rxrxrxrx closed 2 years ago

rxrxrxrx commented 2 years ago

Which package is this bug report for?

candy machine cli

Issue description

I setup my candy machine :

Key: 6v8FFTTNx1LA3Jx6sck2EpspwAo8J6pjXj8Ymfc6hXXX
1st creator : 6XC4ji3U1Bh6A1WK7ctRd2ufknmJ6y5tsADKHzyXXXX
authority:  BjKqKkvh77HdsBhZNBVKem42Hft5CAAWiH5z6b8XXXX
wallet:  BjKqKkvh77HdsBhZNBVKem42Hft5CAAWiH5z6bXXXX
Collection mint:  8NrZMYcMAk2QChiCKJxn8d4ge1Xqz43qXJTYXXXXX
Collection PDA:  DQU7uaY3uVHWVskYJ1B4mH5WPTjXrg3KSj3HXXXXX
tokenMint:  null
uuid:  100000
price:  0
itemsAvailable:  474
itemsRedeemed:  2

I minted 2 NFTs, with mint_one_token command, They show with the good metadata, picture, but in unknown collection.

Here on solcan : https://solscan.io/collection/69f014ac9f2afba4a181b8f43534ea69286b5bdde9f101e6d949cbba349d76fd

Here on my wallet :

Screenshot 2022-06-01 at 10 31 45

I saw a new command with set_collection and -m but I dont get which ID I have to put after the M is it 69f014ac9f2afba4a181b8f43534ea69286b5bdde9f101e6d949cbba349d76fd ?

Also why it seems to be perfect on solscan and not on phantom ? Thanks a lot for your help, I tried to find a solution during hours on this

I have to release this collection asap so, sorry I will put a high priority :/

Command

No response

Relevant log output

No response

Operating system

MacOS

Priority this issue should have

High (immediate attention needed)

Check the Docs First

EF08 commented 2 years ago
Solscan

From your link to solscan, I checked your NFT's Metaplex metadata and found that tokenStandard: 0. For popular collections that trade on Magic Eden like Okay Bears, this field "tokenStandard" doesn't even show up, let alone display a 0 value. I think this suggests that something about your .json files does not comply with the NFT token standard metadata that wallets like Phantom are currently using (which is probably weeks/months old). If I had to speculate what exactly is the deviation from Phantom's standard, it's probably related to the new set_collection command, as this was not in place at the time when the other NFT collections were minting (of which do not have "unknown collection issues on Phantom").

(2) possible solutions:

Either (1): wait for Phantom to integrate this new "set_collection" feature into their NFT standard (maybe msg a dev there and ask when they'll do this?)

or

(2): Re-upload but include "-nc" in the command to turn off the on-chain collection feature from Metaplex (more info on line 117-120 in metaplex/js/packages/cli/src/candy-machine-v2-cli.ts --screenshot included: Screen Shot 2022-06-02 at 6 06 38 PM) This should allow Phantom to show your NFT collection based on it's name.

Let me know your thoughts.

ruskkartel commented 2 years ago

Such a beauty ... Works like a charm

Ran this for the upload and it shows now on phantom though your uploads are prone to bots setting the collections.

ts-node ~/metaplex/js/packages/cli/src/candy-machine-v2-cli.ts upload -e devnet -k keypair.json -nc -cp config.json ./assets

rxrxrxrx commented 2 years ago

Thanks for the help,

So I get this result, it's better, but still, I would like to have the real name and not just "collection NFT" Any way to manage this ?

Screenshot 2022-06-03 at 11 23 22

Or is it because I just re-run the upload command ? is it updating the candy machine well ? Or I have to upload the all collection again ?

EF08 commented 2 years ago

@rxrxrxrx we tested it and it will work if you upload to a new candy machine and add the -nc command. However, if you want to keep the same candy machine and you have updateAuthority + it is a mutable collection (changeable) then you should be able to remove_collection. Described in the screenshot from metaplex docs from here: https://docs.metaplex.com/candy-machine-v2/creating-candy-machine image

Command to remove_collection is:

ts-node ~/metaplex/js/packages/cli/src/candy-machine-v2-cli.ts remove_collection \ -e devnet \ -k ~/.config/solana/devnet.json \ -c example

Try this first ^ if that removes the on-chain collection metadata you should be good to go. Let us know if it works. If it does not, you'll have to re-upload to a new candy machine with -nc in the upload command.

rxrxrxrx commented 2 years ago

Im going to try with -nc. This collection was an airdrop so I manage to set the collection by minting all the nft and update it with metaplex website https://collections.metaplex.com/create-collection

note thats its not possible to remove a collection if you started to mint it !

Thanks for your help guys I will come back here if I have others issue regarding the collection with -nc but it should be good

github-actions[bot] commented 2 years ago

This Issue has received no activity for 30 days. We will close it in 2 days, please reopen if you are still experiencing this issue.