search

metaplex-foundation / mpl-token-metadata

Program to attach additional data to Fungible or Non-Fungible tokens on Solana.
https://developers.metaplex.com/token-metadata
Other
124 stars 65 forks source link

MET-126: Added new option: CollectionDetails::V2 #96

Closed kstepanovdev closed 7 months ago

kstepanovdev commented 7 months ago

Although the new CollectionDetails variant has been added with no additional logic on top, the changes happen to be relatively big. I'd rather completely remove the V1 option with its related methods (or even whole files like bubblegum_set_collection_size), however, I'm worried that would destroy backward compatibility.

kstepanovdev commented 7 months ago

This looks great! One thing to note is that we usually try and split style changes out from feature changes to make reviews easier. Not sure if that was your editor or not, though!

Thanks. tbf, I've done it manually. Should I roll back "style" changes?

blockiosaurus commented 7 months ago

This looks great! One thing to note is that we usually try and split style changes out from feature changes to make reviews easier. Not sure if that was your editor or not, though!

Thanks. tbf, I've done it manually. Should I roll back "style" changes?

Nope you're good to merge. Just a comment for the future.