search

metaplex-foundation / sugar

Candy Machine Rust CLI.
Apache License 2.0
203 stars 116 forks source link

Support Sized Collections #338

Closed samuelvanderwaal closed 2 years ago

samuelvanderwaal commented 2 years ago

Creates sized collections by default when a collection asset pair is included in the assets directory. There's no real disadvantage I see to everyone having sized collections by default, but if someone really doesn't want a sized collection they can still create the collection parent NFT themselves as unsized and then use the set-collection command with Sugar to use it.

Waiting on this feature to be merged and deployed to candy machine devnet to test and finish this PR.

MarkSackerberg commented 2 years ago

Hey,

There's no real disadvantage I see to everyone having sized collections by default

generally that's true and I prefer sized collections, but since the whole collection NFT concept seems to be hard to grasp for many unexperienced people I would prefer to at least add a parameter like --no-sized-collection or something to instead create a unsized collection.

If we don't have that some quite annoying support cases will appear in the discord.

samuelvanderwaal commented 2 years ago

Hey,

There's no real disadvantage I see to everyone having sized collections by default

generally that's true and I prefer sized collections, but since the whole collection NFT concept seems to be hard to grasp for many unexperienced people I would prefer to at least add a parameter like --no-sized-collection or something to instead create a unsized collection.

If we don't have that some quite annoying support cases will appear in the discord.

Can you elaborate on what kind of support cases you would anticipate from this?