search

metaplex-foundation / sugar

Candy Machine Rust CLI.
Apache License 2.0
203 stars 116 forks source link

[Bug]: Run validate before upload #374

Closed KartikSoneji closed 1 year ago

KartikSoneji commented 2 years ago

Issue description

  1. Create invalid json
  2. Run sugar upload
  3. Invalid json is uploaded successfully

Most users don't run sugar validate, so it should be run automatically before the upload command.

Relevant log output

No response

Priority this issue should have

Medium (should be fixed soon)

samuelvanderwaal commented 1 year ago

I think keeping validate gives users more flexibility if they want to upload non-standard JSON files. There's always a trade-off between protecting users every step of the way and adding as much convenience as possible and having flexibility. I think we're currently on the right side of the trade off for this but am open to other thoughts.