[Bug]: maxEditionSupply parameter is ignored

metaplex-foundation / sugar

Candy Machine Rust CLI.

Apache License 2.0

203 stars 116 forks source link

[Bug]: maxEditionSupply parameter is ignored #404

Closed GabrielePicco closed 1 year ago

GabrielePicco commented 1 year ago

Issue description

Steps to reproduce:

set "maxEditionSupply": 100 in the config.json
sugar launch
sugar mint

In the metadata of the minted token the maxSupply is set to 0

Relevant log output

No response

Priority this issue should have

Medium (should be fixed soon)

samuelvanderwaal commented 1 year ago

maxEditionSupply isn't a valid config value. It's probably something we could add, but it seems a bit of a strange use-case to use a candy machine to create master editions with print supplies. Can you elaborate on your use case?

GabrielePicco commented 1 year ago

Thanks @samuelvanderwaal , I wasn't looking at the right place in the documentation. In our use-case we just wanted to have a CandyMachine with master editions that users could print up to a maximum number of times, not sure how common it is tough. I modified this line to achieve it for now. I can open a PR to add it to the config if you think is useful.