metaregistrar / php-epp-client

Object-oriented PHP EPP Client
https://www.metaregistrar.com/docs/
MIT License
214 stars 159 forks source link

No clTRID added for domain:info commands #110

Closed perfectsenseab closed 6 years ago

perfectsenseab commented 6 years ago

I have noticed that the clTRID tag does not seem to be added for domain:info commands. I have tried to track down the place where it gets removed but i have not found it. It seems to only happen for domain:info commands. As a result the EPP servers don't respond with any clTRID.

metaregistrar commented 6 years ago

That is strange, i have not seen this behaviour. The clTRID should be added to all commands. I have tried to run my tests, but that shows that the field actually is there.

<epp xmlns="urn:ietf:params:xml:ns:epp-1.0" xmlns:domain="urn:ietf:params:xml:ns:domain-1.0" xmlns:contact="urn:ietf:params:xml:ns:contact-1.0" xmlns:host="urn:ietf:params:xml:ns:host-1.0" xmlns:polldata="http://www.metaregistrar.com/epp/polldata-1.0" xmlns:command-ext="http://www.metaregistrar.com/epp/command-ext-1.0" xmlns:command-ext-domain="http://www.metaregistrar.com/epp/command-ext-domain-1.0" xmlns:ext="http://www.metaregistrar.com/epp/ext-1.0" xmlns:dns-ext="http://www.metaregistrar.com/epp/dns-ext-1.0" xmlns:secDNS="urn:ietf:params:xml:ns:secDNS-1.1" xmlns:rgp="urn:ietf:params:xml:ns:rgp-1.0">
  <command>
    <info>
      <domain:info>
        <domain:name>54lg3qxsn1a5a0y5dqyj.frl</domain:name>
      </domain:info>
    </info>
    <clTRID>59f863ec65970</clTRID>
  </command>
</epp>

There is no command in the suite that removed this clTRID, there is only a command that removes it and places it back at the end of the EPP. Because some registries have a problem if clTRID is not the last field in EPP.

The command

$this->addSessionId();

will remove the clTRID field and place it back at the end of the EPP command.

metaregistrar commented 6 years ago

Sometimes, when an extension is added, it is placed after the clTRID, maybe the field is in the middle of your EPP command?

perfectsenseab commented 6 years ago

Hello again,

I tracked down the problem. Somehow i had an old version of eppInfoDomainRequest.php. The one i had contained this extra row:

    $this->command = $this->createElement('command');

Why i had an old version of this is beyond me since i installed using composer a couple of days ago and this file was last updated over a year ago. Anyway, when i removed this line the clTRID appeared in the domain:info commands.

2017-10-31 12:58 GMT+01:00 Ewout de Graaf notifications@github.com:

Sometimes, when an extension is added, it is placed after the , maybe the field is in the middle of your EPP command?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/metaregistrar/php-epp-client/issues/110#issuecomment-340740983, or mute the thread https://github.com/notifications/unsubscribe-auth/AKAypPVu2dkrVpnBSuXA0ZLXxmY5OJsrks5sxwtngaJpZM4QMk3g .

-- Med vänlig hälsning, Jimmy Persson Perfect Sense AB / Webb.se | Vasagatan 58, 41137 Göteborg E-post: info@perfectsense.se Webb: https://www.webb.se

Följ oss gärna på Twitter https://twitter.com/webb_Se, Facebook https://www.facebook.com/webbdotse och Google+ https://plus.google.com/+WebbSe_domain/