metaregistrar / php-epp-client

Object-oriented PHP EPP Client
https://www.metaregistrar.com/docs/
MIT License
214 stars 159 forks source link

Readme adjusment #172

Closed edermartins closed 5 years ago

edermartins commented 5 years ago

There are two errors in the README code sample:

  1. Statement new is missing: "$conn = Metaregistrar\EPP\eppConnection();" should be "$conn = new Metaregistrar\EPP\eppConnection();"

  2. Hostname cannot receive the protocol 'ssl://': "$conn->setHostname('ssl://eppltest1.metaregistrar.com');" should be "$conn->setHostname('eppltest1.metaregistrar.com');"

metaregistrar commented 5 years ago

I fixed the first one, the second one i will have to test, because the server should accept SSL connections.

metaregistrar commented 5 years ago

Checked it, and eppltest1.metaregistrar.com does actually support SSL connections over port 7000

Please make sure that your IP address is whitelisted, and make sure that outgoing port 7000 is not blocked on your development environment.

edermartins commented 5 years ago

The php-epp-client uses SSL and works fine to me. But if I put the string 'ssl://server.bla' the system fails and I show that's not possible to connect into 'ssl://ssl://server.bla'. When I use without 'ssl://' it works fine.

metaregistrar commented 5 years ago

Aha, okay, that is specific to the $conn->setHostname('ssl://eppltest1.metaregistrar.com'); method of connecting. Please let me check and fix this, there is a pull request open with a fix.

edermartins commented 5 years ago

Great and thanks :-)

metaregistrar commented 5 years ago

The latest version is redone now to make sure that settings are processed exactly the same way, no matter how they are provided to the system. Added Examples/alternativeconnection.php to test and make sure this works.