Error in getNsgroupHosts

metaregistrar / php-epp-client

Object-oriented PHP EPP Client

https://www.metaregistrar.com/docs/

MIT License

210 stars 154 forks source link

Closed denjaland closed 5 years ago

denjaland commented 5 years ago

Hi,

Just created PR #199 to resolve an issue where the foreach loop was not given the correct array to loop over when getting nsgroup info from DNS BE.

Thanks for pulling it in at your soonest convenience :-)

metaregistrar commented 5 years ago

Merged! Thanks.

denjaland commented 5 years ago

Thanks, @metaregistrar! What is your policy on when you tag a new release?

denjaland commented 5 years ago

Hi again @metaregistrar - any idea on when you're tagging a new release, so I can pull in this change? :-) #prettyplease

denjaland commented 4 years ago

Hi @metaregistrar , can you please release a new version with this fix?

metaregistrar commented 4 years ago

Will do this week.

denjaland commented 4 years ago

Hiya,

You think this week is feasible? I keep forgetting I need to patch this every time we do a new deploy :-)

denjaland commented 4 years ago

Hi @metaregistrar,

Are you still releasing this, or should I just fork it now? Thanks!

David.

metaregistrar commented 4 years ago

Hi David,

My apologies, i forgot the release. Will do it today.

metaregistrar commented 4 years ago

Done, 1.0.8 released