search

metaregistrar / php-epp-client

Object-oriented PHP EPP Client
https://www.metaregistrar.com/docs/
MIT License
210 stars 153 forks source link

Shouldn't this be `include` instead of `require` since it is a private file? #248

Closed lidakaml closed 4 years ago

lidakaml commented 4 years ago

Shouldn't this be include instead of require since it is a private file? Or better yet, You can require this file if testsetup.ini has a parameter like: requireVendorAutoload = true - make the file optional.

https://github.com/metaregistrar/php-epp-client/blob/ff93be65b8b51ee7505c4527a9e0ff972f29588e/Tests/eppTestCase.php#L2

metaregistrar commented 4 years ago

The difference between require() and include() is the type of error that is thrown in the case that the file is not found.

In all cases, if the file is not found, this eppTestCase.php will not work, so the .php file that is included or required MUST be present. When the file is present, there is no difference between require and include.