search

metaregistrar / php-epp-client

Object-oriented PHP EPP Client
https://www.metaregistrar.com/docs/
MIT License
214 stars 159 forks source link

Norid: Fix issue with implicit renew #258

Closed simenandre closed 4 years ago

simenandre commented 4 years ago

Fix issue where domain:authInfo and domain:period elements are ordered wrongly, causing <transfer op="execute" /> commands to fail when trying to implicitly renew.

Error message

Parse error at line [2], column [1871]: Element '{urn:ietf:params:xml:ns:domain-1.0}period': This element is not expected.

Reproduce

To reproduce the issue, you'll need to try moving a domain that has expired. The error you'll get is:

Domain [vg.no] expired 2020-03-18. The transfer command must include a renewal period.

@alexrsagen are you able to recreate this issue?

PS: First time using this library, the EPP protocol is also quite new for me. Expect me to misunderstand stuff 😅

alexrsagen commented 4 years ago

I was able to reproduce the error and was able to verify that your commit fixes the issue.

Thanks for the fix 😄