metaregistrar / php-epp-client

Object-oriented PHP EPP Client
https://www.metaregistrar.com/docs/
MIT License
214 stars 159 forks source link

Added a method to get the reason for verification failure. #273

Closed jansen-s closed 4 years ago

jansen-s commented 4 years ago

1.Added a method to get the reason for verification failure. 2.Optimize the rules for obtaining verification results.

metaregistrar commented 4 years ago

Hello,

Thanks for the addition of the Verisign extension.

However, i am not completely happy with how it is put together.

The extension consists of multiple other EPP extensions, like namestoreExt-1.1 and verificationCode-1.0

I would like to see these extensions in their separate directories, with the correct directory names of namestoreExt-1.1 and verificationCode-1.0. The eppData, eppRequests and eppResponses have to be in their own directories then with their extensions.

Because then if there ever is a namestoreExt-1.2 it can have its own directory, it allows for versioning of the extensions.

Currently, you are adding all different extensions in the 'include.php', this should be done in Registries/verisignEppConnection/eppConnection.php.

This way, all the extensions may be used separately, also by other registries if they want to re-use a Verisign-designed extension.