search

metaregistrar / php-epp-client

Object-oriented PHP EPP Client
https://www.metaregistrar.com/docs/
MIT License
209 stars 153 forks source link

PHP 8.1 #358

Closed W0rma closed 11 months ago

W0rma commented 12 months ago

We are using this package on PHP 8.1 and it is working fine.

However, we notice several PHP deprecation warnings:

Deprecated: Return type of Metaregistrar\EPP\eppResponse::saveXML(?DOMNode $node = null, $options = null) should either be compatible with DOMDocument::saveXML(?DOMNode $node = null, int $options = 0): string|false, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
Deprecated: strlen(): Passing null to parameter #1 ($string) of type string is deprecated
Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated

Are there any plans to tackle them?

Some month ago I created https://github.com/metaregistrar/php-epp-client/pull/346 which should fix the deprecation warnings at least in the classes/methods which are used by us.

metaregistrar commented 11 months ago

A pull request fixing the warnings was approved today, and will be baked into a new version soon