search

metaregistrar / php-epp-client

Object-oriented PHP EPP Client
https://www.metaregistrar.com/docs/
MIT License
214 stars 160 forks source link

Make error handling more consistent for connect() #45

Closed niklam closed 8 years ago

niklam commented 8 years ago

SSL vs. no-SSL connection failures are handled differently. This change makes them behave the same way: do not throw eppException but write to log and return false. This was the behavior for no-SSL connections before.

metaregistrar commented 8 years ago

I don't think i am going to accept this change. Better is to revamp the whole function and make it the same for both with and without a local certification file. But i have to make sure it is not a breaking change for those people that use this code.

niklam commented 8 years ago

I Understand. Makes sense.