search

metaregistrar / php-epp-client

Object-oriented PHP EPP Client
https://www.metaregistrar.com/docs/
MIT License
214 stars 160 forks source link

domain:authInfo element created even if the auth_code is not being provided #67

Closed marcuan closed 7 years ago

marcuan commented 7 years ago

For the eppInfoDomainRequest, the domain:authInfo element is being created even if the auth_code is not provided, this is because in the eppDomain object the authorisation_code is initialized with an empty string value so it avoids the is_null verification used in the eppInfoDomainRequest.

metaregistrar commented 7 years ago

The fix is easy, but i have to test it using our test suites. So far i have seen 3 types of behaviour from the registries: 1 - Some don't want the authcode field at all 2 - Some don't use it, but it must be there otherwise you receive an error 3 - Some use it

The RFC states the AuthInfo field is OPTIONAL, so i will test the fix to set it to null.