lib: change event signature

metarhia / jstp

Fast RPC for browser and Node.js based on TCP, WebSocket, and MDSF

https://metarhia.github.io/jstp

Other

142 stars 10 forks source link

lib: change event signature #187

Closed lundibundi closed 7 years ago

lundibundi commented 7 years ago

Changes event message signature to always send an array of arbitrary arguments. This makes it work same way as EventEmitter does and also makes its usage similar to call action.

Also the tests are just plainly awesome, but we will rewrite them soon anyway.

aqrln commented 7 years ago

@belochub as far as I can tell from the in-person conversation, you weren't extremely happy with this change. Did you change your mind or...?

Defensively marking this as blocked until I'm sure there is consensus about this.

belochub commented 7 years ago

@aqrln, yes, it is okay, I approved the PR after @lundibundi explained to me the point of it.

lundibundi commented 7 years ago

Landed in 852b46c0ac488eb36a8733f18bc6a2b1fed1f153.