metarhia / jstp

Fast RPC for browser and Node.js based on TCP, WebSocket, and MDSF
https://metarhia.github.io/jstp
Other
142 stars 10 forks source link

test: autodetect available browsers in karma #193

Closed lundibundi closed 7 years ago

lundibundi commented 7 years ago

I haven't added karma-ie-launcher as it has been last updated quite a while ago and has a lot of issues, so I'm not sure if we should add it.

Fixes: https://github.com/metarhia/jstp/issues/155

aqrln commented 7 years ago

I suppose it should also fix https://github.com/metarhia/jstp/issues/149.

lundibundi commented 7 years ago

@aqrln I think so too but I haven't tested it therefore I didn't add it. I'll probably test it later before landing it and add fixes if it works.

aqrln commented 7 years ago

@lundibundi Windows fails with Cannot load browser "IE": it is not registered. npm i -D karma-ie-launcher fixes this. The tests themselves fail with SyntaxErrors on IE and Edge though, but that's a matter of a different PR.

aqrln commented 7 years ago

Oh, and can you please rebase onto master and update package-lock.json?

lundibundi commented 7 years ago

@aqrln thanks for testing it on windows. No problem.

lundibundi commented 7 years ago

@aqrln I've updated package.json and added fixes 149, as In my opinion the issue was about starting karma tests on windows and we have to create separate issue dedicated to fixing the errors detected.

Also Arch Linux still hasn't updated npm version, could you please land it and update package-lock.json upon landing?

aqrln commented 7 years ago

@lundibundi

Also Arch Linux still hasn't updated npm version, could you please land it and update package-lock.json upon landing?

npm i -g npm@5 ;) But np, I can update it myself.

lundibundi commented 7 years ago

@aqrln I obviously know of that, but it'll probably break pacman packet and I don't really want to fix that :smile:. Thanks.

aqrln commented 7 years ago

@lundibundi that won't break the pacman package. npm bundled with Node.js and npm installed as a regular global npm package reside in different directories.

aqrln commented 7 years ago

Landed in 6339bb0ce01847fd90f53d94e4581e0d78a2226b.