search

metarhia / jstp

Fast RPC for browser and Node.js based on TCP, WebSocket, and MDSF
https://metarhia.github.io/jstp
Other
143 stars 10 forks source link

lib: remove console.warn() from safeRequire() #216

Closed DzyubSpirit closed 7 years ago

DzyubSpirit commented 7 years ago

Refs: #188

DzyubSpirit commented 7 years ago

@aqrln Could you please say whether that implementation of safeRequire suits the user needs?

nechaido commented 7 years ago

@DzyubSpirit I'd prefer safeReqire() to return tuple [eroor, module] instead.

aqrln commented 7 years ago

@DzyubSpirit ping. Are you still up to working on this?

DzyubSpirit commented 7 years ago

@aqrln Yes, there is metarhia/common#31 about Either type because Either doesn't belong to the scope of this package. Also I've changed package-lock.json but forget to push, thank you for remind.

aqrln commented 7 years ago

Alternative PR: https://github.com/metarhia/jstp/pull/226. Whichever wins the race will land on master.

nechaido commented 7 years ago

Closed in favour of https://github.com/metarhia/jstp/pull/226.