metarhia / jstp

Fast RPC for browser and Node.js based on TCP, WebSocket, and MDSF
https://metarhia.github.io/jstp
Other
143 stars 10 forks source link

parser: parse Unicode identifiers #218

Closed belochub closed 7 years ago

belochub commented 7 years ago

Refs: https://github.com/metarhia/jstp/issues/152

belochub commented 7 years ago

@aqrln, may you help me with creation of pre-build configuration script to make it possible to choose which of the two implementations to use (check out https://github.com/metarhia/jstp/commit/89427481f29d1c50b2cd6ec042493a251cef26cf#diff-9689e209b75f216133f2b377028d89f6R9)?

aqrln commented 7 years ago

@belochub can you please rebase to resolve conflicts?

belochub commented 7 years ago

@aqrln, we can't land it yet, you still haven't addressed https://github.com/metarhia/jstp/pull/218#issuecomment-307757110.

belochub commented 7 years ago

@aqrln, ping.

aqrln commented 7 years ago

@belochub I've pushed a commit to your branch. @nechaido @lundibundi PTAL

aqrln commented 7 years ago

Landed in 4e942ae06d0a291bea37a6c6ffb42642b9842d4f and 4b67cbdb2a50266fa5f6ab6f1760811fc29465e0.