parser: allow numeric literals as object keys

metarhia / jstp

Fast RPC for browser and Node.js based on TCP, WebSocket, and MDSF

https://metarhia.github.io/jstp

Other

143 stars 10 forks source link

parser: allow numeric literals as object keys #223

Closed belochub closed 7 years ago

belochub commented 7 years ago

Refs: https://github.com/metarhia/jstp/issues/152

belochub commented 7 years ago

@nechaido, ping.

belochub commented 7 years ago

@nechaido, adding the test you proposed to /test/fixtures/serde-test-cases/serde.js, will definitely break the build, this doesn't belong to regular test cases yet, in my opinion, it should be added to current json5 tests because it belongs to json5 specification and it isn't implemented in JavaScript parser yet, which makes it a "to do" test case for now. I will add the corresponding test to json5 test cases if you don't mind.

nechaido commented 7 years ago

@belochub you are right, go ahead.

belochub commented 7 years ago

@nechaido, I've added the test, PTAL.

aqrln commented 7 years ago

Landed in 635ea15ccbfa540e4d9b84dda26ab40561d487ca.